fix(links): update check relative links - #535
Merged
Merged
Conversation
ChronosSF
approved these changes
Sep 8, 2026
ChronosSF
left a comment
Member
There was a problem hiding this comment.
Verified the description against the repo and ran the new script against a fully generated local tree:
- Both content configs root the docs collection at
components, so the/components/...prefix rejection is correct, and the oldresolve(langRoot, path)fallback was indeed what let #530 through. - Astro 7.2.6 strips a trailing
/indexfrom slugs, so the index-page candidates match what publishes. - The toc check mirrors
docExists()insrc/sidebar.ts(as-written plus.md/.mdxswap), and the not-synced-to-Angular filter matchesshouldCopy()insync-generated.mjs. - Against my local tree the PR script reports exactly the two
/components/inputs/button-grouplinks for Angular and the stalegrids/theming-grid.mdxtoc entry for the three xplat platforms, while the base script reported 81 Angular "not found" links that were all xplat-authored topics not yet synced locally. The second content root resolves those as intended. - The jp counterparts need no change: both jp Angular topics already use relative links, and the jp xplat source still has the grid theming page at
grids/theming-grid.mdx, so its toc entry is consistent.
LGTM.
16 tasks
ChronosSF
added a commit
that referenced
this pull request
Sep 15, 2026
#535, #491 (#556) * docs(jp): sync Angular JP docs with EN PRs #522, #438, #535, #491 Manual replay of the four failed "Sync Japanese Documentation (Angular)" runs (33877005832, 34238718782, 34250163709, 34329511530). Each died in the Copilot CLI step with transient_bad_request before doing any work; the workflows have since been recompiled with gh-aw v0.88.7 in #555. - chat: translate the `messages` row and the new bidirectional messages collection section (#438) - theming-mcp: add the WCAG contrast note linking to the new Accessibility topic (#522) - palettes: hsla() contrast variables in the CSS excerpt (#522) - toc: add Themes > Accessibility; Button now points at inputs/button.mdx (#522, #491) - retarget IgxButton links in dialog, time-picker, tooltip, roundness, material/bootstrap theming and the row-editing/search grid templates to the xplat-generated inputs/button page (#491, #535) - remove the hand-authored button.mdx and layouts/avatar.mdx, superseded by the xplat-generated pages exactly as EN did (#491, #522) - xplat jp toc: lift the Angular exclude on Button, Icon, Icon Button and Avatar and add Themes > Accessibility, mirroring the EN xplat toc so the Angular JP site gains the generated pages the Angular toc now references - add the jp xplat themes/accessibility.mdx translation (target of the new toc entry and of the theming-mcp note) - mirror the new button anatomy / do-don't images into jp/images, which the Angular build resolves per language via @xplat-images Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(jp): sync xplat JP docs with EN PRs #522, #438, #535, #491 Manual replay of the four failed "Sync Japanese Documentation (xplat)" runs (33877005838, 34238718784, 34250163990, 34329511576), which died in the Copilot CLI step exactly like their Angular counterparts. Change set is the EN diff under docs/xplat/src/content/en/ since the last successful xplat sync (d346871), filtered to TOC-covered files per the workflow. - inputs/button: re-mirror the rewritten EN topic (anatomy, getting started, usage/variants/states/layout/size/download/do-don't, properties, styling incl. Tailwind, accessibility, troubleshooting, dependencies, related, FAQ), reusing existing JP prose where EN kept it. The Getting Started link is split per platform like the JP badge and button-group pages, because the JP xplat toc still excludes general-getting-started.mdx for Angular (EN does not) - inputs/button-group: Angular-specific PlatformBlocks throughout, {PackageCommon} install block, per-platform properties tables, API references and dependencies, new Related/FAQ content - inputs/badge: {PackageCommon} install block, Angular import sentence, CSS variables table, troubleshooting/FAQ updates - interactivity/accessibility-compliance: replace the Section 508 / WCAG matrices with the new standards, criteria, per-component documentation index (JP heading anchors), configuration, VPAT and FAQ sections - interactivity/chat: Blazor MessageCreated guidance, per-platform property names, bidirectional messages collection section - themes/overview: configureTheme variant argument, new Customizing with Sass section; themes/accessibility now anchors to it - themes/palettes: runtime relative-color contrast, seed variables, --ig-wcag-* excerpt, contrast-level note - ai/theming-mcp: WCAG contrast note Not mirrored: the EN toc href fix for grids/grid/theming-grid.mdx (#535) only corrected EN after a July file move (#355) that was never applied to JP; JP still keeps the page at grids/theming-grid.mdx consistently. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * review: apply native check fixes (fix wording inconsistencies) * review: apply native check fixes (reword literal "boundaries" translation in troubleshooting intros and known-limitations lead-in) * review: apply native check fixes (reword literal "boundaries" translation in the Before You Start lead-in) * review: apply native check fixes (restore accessibility anchors on carousel and tooltip links) --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: jsakamotoIGJP <jsakamoto@infragistics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #530.
Problem
list.mdxandthemes/roundness.mdxlinked Button Group as/components/inputs/button-group, which 404s andcheck-relative-linkspassed.The docs collection is rooted at
content/<lang>/components(
docs/*/src/content.config.ts), socomponents/is never a URL segment.#468 moved the topic into xplat, which legitimately changed its URL from
/button-groupto/inputs/button-group, but the links were rewritten with thenew file path rather than the new URL. (The same commit updated
toc.jsoncorrectly, because toc hrefs really are file paths.)
The check couldn't catch it:
resolveAbsoluteLinkcarried a fallback candidate,resolve(langRoot, path), encoding that same wrong model. The bad link matched areal file on disk, so CI went green. That fallback had been there since the
checker landed in #355.
Content
/inputs/button-group.Grid → Themingentry pointed at a page that doesn'texist in EN and was being silently dropped from the sidebar on all three xplat
sites.